Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Features::RG11B10UFLOAT_RENDERABLE #3701

Merged
merged 2 commits into from
Apr 19, 2023

Conversation

jinleili
Copy link
Contributor

@jinleili jinleili commented Apr 18, 2023

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.

Connections
#3689
resolves #3268

Testing
Tested locally

Copy link
Collaborator

@crowlKats crowlKats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deno part LGTM

Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the comment it looks great! Thanks!

wgpu/src/backend/web.rs Outdated Show resolved Hide resolved
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After comment is addressed secondary g2g :)

Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

@teoxoy
Copy link
Member

teoxoy commented Apr 19, 2023

@jinleili would you like to also reference this PR and your username in the existing changelog entry?

@jinleili
Copy link
Contributor Author

@jinleili would you like to also reference this PR and your username in the existing changelog entry?

I prefer not to reference my username in the changelog. Thanks.

@teoxoy teoxoy merged commit 62ea781 into gfx-rs:trunk Apr 19, 2023
@PJB3005 PJB3005 mentioned this pull request May 28, 2023
37 tasks
@jinleili jinleili deleted the RG11B10UFLOAT branch June 23, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Features::RG11B10UFLOAT_RENDERABLE
4 participants