Fix missing 4X MSAA support on some OpenGL backends #3780
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy
.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown
if applicable.Connections
Description
A regression was introduced in wgpu 0.15 by #3140, where some GL backends would report a minimum supported MSAA of 2x. However, GLES3.0 (and therefore WebGL2) guarantees at least 4x.
This problem manifests itself on some versions of iOS Safari, where
get_parameter_i32(glow::MAX_SAMPLES)
returns0
(for unknown reasons - maybe anti-fingerprinting?), even though 4x MSAA is supported.Testing
Tested on iOS Safari. Before the fix I got:
After the fix, everything works (with 4x MSAA).