Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back components info of TextureFormats #3843

Merged
merged 2 commits into from
Jun 6, 2023
Merged

Add back components info of TextureFormats #3843

merged 2 commits into from
Jun 6, 2023

Conversation

teoxoy
Copy link
Member

@teoxoy teoxoy commented Jun 6, 2023

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Connections
fixes #3837

Wumpf
Wumpf approved these changes Jun 6, 2023
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice to have that back. Lgtm!
(Was stumbling over the lack of this method myself as well but didn't think much of it)

@Wumpf Wumpf merged commit 2e4209c into gfx-rs:trunk Jun 6, 2023
@teoxoy teoxoy deleted the components branch June 6, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Component count for texture formats was (accidentally?) removed from wgpu types
2 participants
@teoxoy @Wumpf