Revert "Make shader write&read storage buffers match non readonly layouts" #3984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…outs (gfx-rs#3893)" This reverts commit 17143c1.
cwfitzgerald
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 17143c1 (#3893) as it changed validation in a non-spec compliant way.
Relevant Spec Text:
Even if we want to relax the validation, this won't work for dx12 as we use UAVs for read-write storage buffers and SRVs for read-only storage buffers.
I think we should remove write-only storage buffers as they are not part of the spec anymore (avoiding #2897 altogether). Related: #4411
Found while investigating #3983.