Fix GL Push Constant Layout #4607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
commented
Oct 29, 2023
teoxoy
requested changes
Nov 3, 2023
teoxoy
approved these changes
Nov 6, 2023
|
Can't merge, there seem to be some conflicts now. |
|
Weird, I could merge from my phone |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.cargo clippy --target wasm32-unknown-unknownif applicable.Connections
Closes #3375
Closes #3822
Description
We had multiple issues with the push constant layout algorithm. OpenGL's DCE of uniforms easily threw it off.
This completely reworks how we assert the locations of things, and improves our ability to upload the uniforms.
Depends on grovesNL/glow#265
Testing
It is tested!