Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that pipeline creation errors register layouts as errors also #4624

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
81d5908
Ensure that pipeline creation errors register layouts as errors also
bradwerth Nov 2, 2023
b2c8b81
Updated CHANGELOG.md.
bradwerth Nov 3, 2023
4d28bb7
Merge branch 'trunk' into registerImplicitPipelineLayouts
bradwerth Nov 3, 2023
7a345b6
Before adding errors, remove existing elements, if present.
bradwerth Nov 3, 2023
9501ccc
Use HLSL 2018 (#4629)
daxpedda Nov 4, 2023
dfa7e2f
Fix publish script
cwfitzgerald Nov 5, 2023
8547226
Rewrite Example Event Loop (#4634)
cwfitzgerald Nov 6, 2023
873f19d
Fix Panic in Surface Configure (#4635)
cwfitzgerald Nov 6, 2023
bc7f4be
Fix wasm examples (#4639)
cwfitzgerald Nov 6, 2023
e7e2f2a
vulkan: Log validation layer messages during instance creation/destru…
exrook Nov 6, 2023
b9b4a41
Bump libc from 0.2.149 to 0.2.150 (#4636)
dependabot[bot] Nov 6, 2023
fe1429b
Bump wasm-bindgen-test from 0.3.37 to 0.3.38 (#4637)
dependabot[bot] Nov 6, 2023
0004e96
Bump syn from 2.0.38 to 2.0.39 (#4638)
dependabot[bot] Nov 6, 2023
0dad159
Pass 3 on examples (#4640)
cwfitzgerald Nov 6, 2023
267bd48
[naga wgsl-in] Introduce `Scalar` type.
jimblandy Nov 5, 2023
7f72c9f
Fix GL Push Constant Layout (#4607)
cwfitzgerald Nov 6, 2023
261cb7c
Check if `source` is empty when constructing `hal::DebugSource`
teoxoy Nov 6, 2023
1d4fa81
Gate usage of `metal::ComputePassDescriptor` on timestamp query suppo…
teoxoy Nov 6, 2023
70d8004
Review fixes.
bradwerth Nov 6, 2023
6387ed9
Ensure that pipeline creation errors register layouts as errors also
bradwerth Nov 2, 2023
ed1a520
Updated CHANGELOG.md.
bradwerth Nov 3, 2023
fa0adbd
Before adding errors, remove existing elements, if present.
bradwerth Nov 3, 2023
b9b9b4f
Review fixes.
bradwerth Nov 6, 2023
b1049df
Merge branch 'registerImplicitPipelineLayouts' of https://github.com/…
bradwerth Nov 6, 2023
fb3de58
Ensure that pipeline creation errors register layouts as errors also
bradwerth Nov 2, 2023
8f2db1a
Before adding errors, remove existing elements, if present.
bradwerth Nov 3, 2023
7fbe0a0
Merge branch 'registerImplicitPipelineLayouts' of https://github.com/…
bradwerth Nov 6, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,16 @@ jobs:
- name: Install Rust WASM target
run: rustup target add wasm32-unknown-unknown

- name: Install wasm-bindgen-cli
run: cargo +stable install wasm-bindgen-cli --version=0.2.87
- name: Get wasm-bindgen version
run: |
WASM_BINDGEN_VERSION=$(cargo metadata --format-version 1 --all-features | jq '.packages[] | select(.name == "wasm-bindgen") | .version' | tr -d '"')

echo $WASM_BINDGEN_VERSION

echo "WASM_BINDGEN_VERSION=$WASM_BINDGEN_VERSION" >> "$GITHUB_ENV"

- name: Pin wasm-bindgen version
run: cargo update -p wasm-bindgen --precise 0.2.87
- name: Install wasm-bindgen
run: cargo +stable install wasm-bindgen-cli --version=$WASM_BINDGEN_VERSION

- name: Build WebGPU examples
run: cargo build --release --target wasm32-unknown-unknown
Expand Down
13 changes: 10 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,12 @@ Bottom level categories:

For naga changelogs at or before v0.14.0. See [naga's changelog](naga/CHANGELOG.md).

### Changes

#### General

- Log vulkan validation layer messages during instance creation and destruction: By @exrook in [#4586](https://github.com/gfx-rs/wgpu/pull/4586)

### Bug Fixes

#### WGL
Expand All @@ -67,7 +73,7 @@ By @Zoxc in [#4248](https://github.com/gfx-rs/wgpu/pull/4248)
Timestamp queries are now supported on both Metal and Desktop OpenGL. On Apple chips on Metal, they only support timestamp queries in command buffers or in the renderpass descriptor,
they do not support them inside a pass.

Metal: By @Wumpf in [#4008](https://github.com/gfx-rs/wgpu/pull/4008)
Metal: By @Wumpf in [#4008](https://github.com/gfx-rs/wgpu/pull/4008)
OpenGL: By @Zoxc in [#4267](https://github.com/gfx-rs/wgpu/pull/4267)

### Render/Compute Pass Query Writes
Expand Down Expand Up @@ -190,7 +196,7 @@ let instance = wgpu::Instance::new(InstanceDescriptor {
});
```

`gles_minor_version`: By @PJB3005 in [#3998](https://github.com/gfx-rs/wgpu/pull/3998)
`gles_minor_version`: By @PJB3005 in [#3998](https://github.com/gfx-rs/wgpu/pull/3998)
`flags`: By @nical in [#4230](https://github.com/gfx-rs/wgpu/pull/4230)

### Many New Examples!
Expand Down Expand Up @@ -236,7 +242,7 @@ By @teoxoy in [#4185](https://github.com/gfx-rs/wgpu/pull/4185)
- Add trace-level logging for most entry points in wgpu-core By @nical in [4183](https://github.com/gfx-rs/wgpu/pull/4183)
- Add `Rgb10a2Uint` format. By @teoxoy in [4199](https://github.com/gfx-rs/wgpu/pull/4199)
- Validate that resources are used on the right device. By @nical in [4207](https://github.com/gfx-rs/wgpu/pull/4207)
- Expose instance flags.
- Expose instance flags.
- Add support for the bgra8unorm-storage feature. By @jinleili and @nical in [#4228](https://github.com/gfx-rs/wgpu/pull/4228)
- Calls to lost devices now return `DeviceError::Lost` instead of `DeviceError::Invalid`. By @bradwerth in [#4238]([https://github.com/gfx-rs/wgpu/pull/4238])
- Let the `"strict_asserts"` feature enable check that wgpu-core's lock-ordering tokens are unique per thread. By @jimblandy in [#4258]([https://github.com/gfx-rs/wgpu/pull/4258])
Expand Down Expand Up @@ -265,6 +271,7 @@ By @teoxoy in [#4185](https://github.com/gfx-rs/wgpu/pull/4185)
- Fix `clear` texture views being leaked when `wgpu::SurfaceTexture` is dropped before it is presented. By @rajveermalviya in [#4057](https://github.com/gfx-rs/wgpu/pull/4057).
- Add `Feature::SHADER_UNUSED_VERTEX_OUTPUT` to allow unused vertex shader outputs. By @Aaron1011 in [#4116](https://github.com/gfx-rs/wgpu/pull/4116).
- Fix a panic in `surface_configure`. By @nical in [#4220](https://github.com/gfx-rs/wgpu/pull/4220) and [#4227](https://github.com/gfx-rs/wgpu/pull/4227)
- Pipelines register their implicit layouts in error cases. By @bradwerth in [#4624](https://github.com/gfx-rs/wgpu/pull/4624)

#### Vulkan

Expand Down
80 changes: 46 additions & 34 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ ctor = "0.2"
# https://github.com/SiegeEngine/ddsfile/issues/15 (Updated dependencies)
ddsfile = { version = "0.5.2-unstable", git = "https://github.com/SiegeEngine/ddsfile.git", rev = "9b597930edc00502391cbb1a39708dadde0fd0ff" }
env_logger = "0.10"
fern = "0.6"
flume = "0.11"
futures-lite = "1"
futures-intrusive = "0.5"
Expand Down Expand Up @@ -160,6 +161,7 @@ js-sys = "0.3.65"
wasm-bindgen = "0.2.87"
wasm-bindgen-futures = "0.4.38"
wasm-bindgen-test = "0.3"
web-time = "0.2.3"
web-sys = "0.3.64"

# deno dependencies
Expand Down
Binary file modified examples/bunnymark/screenshot.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Loading