Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[naga] Preserve spans when compacting Arenas. #4696

Merged
merged 1 commit into from
Nov 16, 2023
Merged

[naga] Preserve spans when compacting Arenas. #4696

merged 1 commit into from
Nov 16, 2023

Conversation

jimblandy
Copy link
Member

@jimblandy jimblandy commented Nov 16, 2023 •
edited
Loading

When compacting a module, properly adjust spans along with Arena contents.

Checklist

  • Run cargo clippy.
  • Run cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@jimblandy jimblandy added type: bug Something isn't working naga Shader Translator kind: diagnostics Error message should be better labels Nov 16, 2023
@jimblandy jimblandy requested a review from a team as a code owner November 16, 2023 02:52
@jimblandy
[naga] Preserve spans when compacting Arenas.
3b032d7 
When compacting a module, properly adjust spans along with `Arena`
contents.
teoxoy
teoxoy approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teoxoy teoxoy merged commit 3ec547c into gfx-rs:trunk Nov 16, 2023
27 checks passed
@jimblandy jimblandy deleted the compact-preserve-spans branch December 13, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoxoy teoxoy teoxoy approved these changes

Assignees
No one assigned
Labels
kind: diagnostics Error message should be better naga Shader Translator type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimblandy @teoxoy