Remove DX11 backend #4828

valaphee · 2023-12-04T20:29:27Z

Connections
#4797

Description
This backend had no functionality, and is mainly just boilerplate.

Testing

Checklist

Run cargo fmt.
Run cargo clippy. If applicable, add:
- --target wasm32-unknown-unknown
- --target wasm32-unknown-emscripten
Run cargo xtask test to run tests.
Add change to CHANGELOG.md. See simple instructions inside file.

Also updated etc/big-picture.png, and all references should be removed except in the changelog, logically.

valaphee · 2023-12-04T20:38:17Z

Should I also update the backend ids?

wgpu/wgpu-types/src/lib.rs

Line 106 in a418b60

Gl = 5,

Gl would become 4 and WebGPU = 5

crowlKats

no comment for deno changes.

…ry image compared to exporting svg, and then exporting it to png but text is cropped of)

wgpu-core/src/id.rs

…eb3c29ef785. r=webgpu-reviewers,supply-chain-reviewers,jimb # Changelog * #4807 Bump wasm-bindgen-test from 0.3.38 to 0.3.39 By dependabot[bot] in gfx-rs/wgpu#4807 * #4830 Use Display instead of Debug to log errors. By nical in gfx-rs/wgpu#4830 * #4755 [naga wgsl-in] Automatic conversions for `var` initializers. By jimblandy in gfx-rs/wgpu#4755 * #4755 [naga wgsl-in] Automatic conversions for `var` initializers. By jimblandy in gfx-rs/wgpu#4755 * #4755 [naga wgsl-in] Automatic conversions for `var` initializers. By jimblandy in gfx-rs/wgpu#4755 * #4832 vulkan: fix multi-planar texture creation By xiaopengli89 in gfx-rs/wgpu#4832 * #4758 [vk] remove (old) unused blocklist for dual source blending By teoxoy in gfx-rs/wgpu#4758 * #4828 Remove DX11 backend By valaphee in gfx-rs/wgpu#4828 * #4836 [gl] add support for line and point polygon modes By valaphee in gfx-rs/wgpu#4836 * #4820 Bump futures-lite from 2.0.1 to 2.1.0 By dependabot[bot] in gfx-rs/wgpu#4820 * #4811 Expose shader validation By daxpedda in gfx-rs/wgpu#4811 * #3507 [wgpu-hal] Inline RayQuery Support By daniel-keitel in gfx-rs/wgpu#3507 * #4726 Fix Javascript exception on repeated `BufferSlice::get_mapped_range` calls By DouglasDwyer in gfx-rs/wgpu#4726 * #4841 Remove `expose-ids` Feature By cwfitzgerald in gfx-rs/wgpu#4841 * #4843 Some Minor `wgpu-core` Cleanups By cwfitzgerald in gfx-rs/wgpu#4843 * #4844 Work around cbindgen issue By nical in gfx-rs/wgpu#4844 Differential Revision: https://phabricator.services.mozilla.com/D195735

…eb3c29ef785. r=webgpu-reviewers,supply-chain-reviewers,jimb # Changelog * #4807 Bump wasm-bindgen-test from 0.3.38 to 0.3.39 By dependabot[bot] in gfx-rs/wgpu#4807 * #4830 Use Display instead of Debug to log errors. By nical in gfx-rs/wgpu#4830 * #4755 [naga wgsl-in] Automatic conversions for `var` initializers. By jimblandy in gfx-rs/wgpu#4755 * #4755 [naga wgsl-in] Automatic conversions for `var` initializers. By jimblandy in gfx-rs/wgpu#4755 * #4755 [naga wgsl-in] Automatic conversions for `var` initializers. By jimblandy in gfx-rs/wgpu#4755 * #4832 vulkan: fix multi-planar texture creation By xiaopengli89 in gfx-rs/wgpu#4832 * #4758 [vk] remove (old) unused blocklist for dual source blending By teoxoy in gfx-rs/wgpu#4758 * #4828 Remove DX11 backend By valaphee in gfx-rs/wgpu#4828 * #4836 [gl] add support for line and point polygon modes By valaphee in gfx-rs/wgpu#4836 * #4820 Bump futures-lite from 2.0.1 to 2.1.0 By dependabot[bot] in gfx-rs/wgpu#4820 * #4811 Expose shader validation By daxpedda in gfx-rs/wgpu#4811 * #3507 [wgpu-hal] Inline RayQuery Support By daniel-keitel in gfx-rs/wgpu#3507 * #4726 Fix Javascript exception on repeated `BufferSlice::get_mapped_range` calls By DouglasDwyer in gfx-rs/wgpu#4726 * #4841 Remove `expose-ids` Feature By cwfitzgerald in gfx-rs/wgpu#4841 * #4843 Some Minor `wgpu-core` Cleanups By cwfitzgerald in gfx-rs/wgpu#4843 * #4844 Work around cbindgen issue By nical in gfx-rs/wgpu#4844 Differential Revision: https://phabricator.services.mozilla.com/D195735 UltraBlame original commit: 0dfeaf41028d13f9dd98b106e262c1deb255398d

valaphee requested a review from a team December 4, 2023 20:29

valaphee requested a review from a team as a code owner December 4, 2023 20:29

crowlKats reviewed Dec 5, 2023

View reviewed changes

valaphee added 3 commits December 6, 2023 19:39

Remove dx11

3ce78dc

Update changelog

1ca7bdc

Fix big picture (exporting on app.diagrams.net results in a more blur…

d922c6a

…ry image compared to exporting svg, and then exporting it to png but text is cropped of)

valaphee force-pushed the remove-dx11 branch from 113b65a to d922c6a Compare December 6, 2023 18:39

cwfitzgerald approved these changes Dec 6, 2023

View reviewed changes

wgpu-core/src/id.rs Show resolved Hide resolved

Renumber backends

607b7c5

cwfitzgerald merged commit a1fafe3 into gfx-rs:trunk Dec 6, 2023
27 checks passed

daxpedda mentioned this pull request Dec 8, 2023

Add wgpu crate features for backends #4815

Merged

bradwerth pushed a commit to bradwerth/wgpu that referenced this pull request Dec 8, 2023

Remove DX11 backend (gfx-rs#4828)

7cdc3e1

valaphee deleted the remove-dx11 branch December 21, 2023 22:13

daxpedda mentioned this pull request Jan 12, 2024

Add cfg_aliases to wgpu-core and wgpu-hal #5055

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove DX11 backend #4828

Remove DX11 backend #4828

valaphee commented Dec 4, 2023

valaphee commented Dec 4, 2023 •

edited

Loading

crowlKats left a comment

Remove DX11 backend #4828

Remove DX11 backend #4828

Conversation

valaphee commented Dec 4, 2023

valaphee commented Dec 4, 2023 • edited Loading

crowlKats left a comment

Choose a reason for hiding this comment

valaphee commented Dec 4, 2023 •

edited

Loading