Unify surface creation by introducing new SurfaceTarget
enum
#4984
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Came up while talking about #2804 since all the different surface creation code paths were a bit in the way when working on this.
Description
Unifies all
create_surface_X
methods to justcreate_surface
by expecting a newSurfaceTarget
enum.To be accurate, we're expecting
Into<SurfaceTarget>
which allows to pass anything that implements raw window handle directly.Was a bit unsure about the
create_surface_raw
one. I think removing it in the way I did is correct, but I'm wonder if I blocked some usecases or made things less safe.Future work:
Testing
Compiles! Also ran examples on native (mac) and webgl.
Checklist
cargo fmt
.cargo clippy
. If applicable, add:--target wasm32-unknown-unknown
--target wasm32-unknown-emscripten
cargo xtask test
to run tests.CHANGELOG.md
. See simple instructions inside file.