Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track the actual size of the buffer for memory init #5014

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Track the actual size of the buffer for memory init #5014

merged 1 commit into from
Jan 8, 2024

Conversation

nical
Copy link
Contributor

@nical nical commented Jan 8, 2024

Connections

Fixes #4731

Description

The init tracking code was using the buffer's requested size rather than the actual size which aligned specifically for the purpose of the requirements of initializing/clearing.

Testing

Covered by the CTS.

Checklist

  • Run cargo fmt.
  • Run cargo clippy.
  • Run cargo xtask test to run tests.

@nical nical requested a review from a team as a code owner January 8, 2024 16:14
Wumpf
Wumpf approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, good catch

@nical nical merged commit c6eea50 into gfx-rs:trunk Jan 8, 2024
26 checks passed
@nical nical deleted the clear-align branch January 8, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic Buffer has an uninitialized range with an end not aligned to 4 (end was 31) if buffer size is 31
2 participants
@nical @Wumpf