Don't depend on validation layers for setting object names #5345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimblandy
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Fixes #3913
Description
Before this PR, you needed to use the
VALIDATIONinstance flag to get labels set on Vulkan objects properly, because of an oversight in the PR linked in the issue.This changes it so that only the
DEBUGflag is required againTesting
I tested the water example in renderdoc (in release mode, so no debug_assertions) with
WGPU_DEBUG=1with and without this PR, and saw that the labels were correctly present after this PR.Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknownN/A--target wasm32-unknown-emscriptenN/Acargo xtask testto run tests. Same failures as onmainCHANGELOG.md. See simple instructions inside file.