Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give short example of WGSL push_constant syntax. #5393

Merged
merged 1 commit into from
Mar 16, 2024

Conversation

waywardmonkeys
Copy link
Contributor

@waywardmonkeys waywardmonkeys commented Mar 15, 2024

Connections
None

Description
The existing comment referred to the GLSL syntax but didn't give an indication of how to use it within WGSL.

Testing
Visual inspection, ran tests to be sure nothing broke.

Checklist

  • Run cargo fmt.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@waywardmonkeys waywardmonkeys requested a review from a team as a code owner March 15, 2024 04:20
The existing comment referred to the GLSL syntax but didn't give
an indication of how to use it within WGSL.
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice

@cwfitzgerald cwfitzgerald merged commit fe91958 into gfx-rs:trunk Mar 16, 2024
27 checks passed
@waywardmonkeys waywardmonkeys deleted the push-constant-wgsl branch March 24, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants