Add recursion limit for curly braces in WGSL #5447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErichDonGubler
added
area: validation
jimblandy
reviewed
Mar 27, 2024
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ErichDonGubler
force-pushed
the
limit-wgsl-statement-nesting
branch
3 times, most recently
from
8c520cf
to
60a072e
Compare
ErichDonGubler
changed the title
ErichDonGubler
commented
Mar 28, 2024
This comment was marked as resolved.
This comment was marked as resolved.
ErichDonGubler
commented
Mar 29, 2024
ErichDonGubler
force-pushed
the
limit-wgsl-statement-nesting
branch
2 times, most recently
from
b943742
to
6c7ea07
Compare
ErichDonGubler
changed the title
ErichDonGubler
force-pushed
the
limit-wgsl-statement-nesting
branch
from
6c7ea07
to
22c80fb
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ErichDonGubler
force-pushed
the
limit-wgsl-statement-nesting
branch
from
22c80fb
to
8cdd967
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as duplicate.
This comment was marked as duplicate.
ErichDonGubler
force-pushed
the
limit-wgsl-statement-nesting
branch
from
c19fa79
to
3aed6da
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Link to the issues addressed by this PR, or dependent PRs in other repositories
Intended to resolve #4352.
Description
Describe what problem this is solving, and how it's solved.
Testing
Explain how this change is tested.
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.