-
Notifications
You must be signed in to change notification settings - Fork 943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Satisfy Rust 1.78's latest easy lints #5651
Satisfy Rust 1.78's latest easy lints #5651
Conversation
Any reason not to make the repo msrv 1.78? |
@cwfitzgerald: Mostly because Firefox's current MSRV is 1.76.0, and I'm not sure that I'd want to go up to bat for bumping the MSRV in |
I'm also a bit wary of going with the latest right away on a library like wgpu. There's been bugfixes to a bunch of rust versions and it would be unfortunate to force users onto a new rust version too early |
Context: Strong opinion weekly held, etc @ErichDonGubler we have separate MSRVs for the repository as a whole and core/hal/types/naga - as long as the changes introduced by clippy don't cause the code to break on the lower msrvs (which we have a CI job to test) we can keep our repo msrv wherever we want. @Wumpf counterpoint, no one is going to see this version of wgpu until at least 1.80 is out Would just be nice to enforce these things in CI instead of sporadically |
Good counterpoint! Since you bring up keeping ci at a different version: |
I was suggesting bumping the repo msrv, which includes both the |
@cwfitzgerald: My only hesitation is when Clippy eagerly recommends something that only a newer version of Rust can do. I can't remember the concrete example ATM, but I remember this happening sometime in the last year or so. |
Just waiting on @gfx-rs/naga here. Maybe @teoxoy could rubber-stamp? 😀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Connections
Link to the issues addressed by this PR, or dependent PRs in other repositories
Description
Describe what problem this is solving, and how it's solved.
This hopefully helps some eventual migration we'll do when we set the MSRV to Rust 1.78 or greater.
Testing
Explain how this change is tested.
CI FTW!
Checklist
cargo fmt
.cargo clippy
. If applicable, add:--target wasm32-unknown-unknown
--target wasm32-unknown-emscripten
cargo xtask test
to run tests.Add change toI don't think we need this.CHANGELOG.md
. See simple instructions inside file.