Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[d3d12] handle known error variants returned by D3D12CreateDevice #6241

Merged
merged 1 commit into from
Sep 9, 2024
Merged

[d3d12] handle known error variants returned by D3D12CreateDevice #6241

merged 1 commit into from
Sep 9, 2024

Conversation

teoxoy
Copy link
Member

@teoxoy teoxoy commented Sep 9, 2024

@teoxoy teoxoy requested a review from a team as a code owner September 9, 2024 12:08
@ErichDonGubler ErichDonGubler merged commit 0553729 into gfx-rs:trunk Sep 9, 2024
25 checks passed
@teoxoy teoxoy deleted the d3d12-create-device-handle-err branch September 9, 2024 13:04
@jimblandy
Copy link
Member

This is surprising:

.ok()??

But given that Result<Option<_>> needs to be turned into Option<Option<_>> in order to use ? here at all, I guess this is actually the most reasonable approach.

@teoxoy teoxoy mentioned this pull request Sep 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErichDonGubler ErichDonGubler ErichDonGubler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@teoxoy @jimblandy @ErichDonGubler