Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[naga msl-out] Implement atomicCompareExchangeWeak for MSL backend #6265

Merged

Conversation

AsherJingkongChen
Copy link
Contributor

@AsherJingkongChen AsherJingkongChen commented Sep 13, 2024

Connections

Fixes #5257 and #4364 (partially).
Closes #5675.

Description

Implement atomicCompareExchangeWeak for MSL (Metal) backend.

Please see Metal Specification 2024-06-06, Page 249 for support details.

Testing

I enabled and validated 2 snapshots for Metal.

Checklist

  • Run cargo fmt.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@AsherJingkongChen AsherJingkongChen requested a review from a team as a code owner September 13, 2024 14:28
@jimblandy
Copy link
Member

See also #5675

@AsherJingkongChen
Copy link
Contributor Author

AsherJingkongChen commented Sep 19, 2024

See also #5675

@jimblandy I understand that @9291Sam opened another similar PR, but the progress seems a bit slow. Since this branch is for my own project, I was hoping for quicker updates. That's why I decided to contribute.

@jimblandy
Copy link
Member

@jimblandy I understand that @9291Sam opened another similar PR, but the progress seems a bit slow. Since this branch is for my own project, I was hoping for quicker updates. That's why I decided to contribute.

Oh, definitely. I think we should probably review this PR instead. I just wanted to have the linkage there so that people could find the relationship if they wanted.

naga/src/back/msl/writer.rs Outdated Show resolved Hide resolved
naga/src/back/msl/writer.rs Outdated Show resolved Hide resolved
naga/src/back/msl/writer.rs Outdated Show resolved Hide resolved
@AsherJingkongChen AsherJingkongChen force-pushed the pr/naga/msl/atomic-compare-exchange branch from b42d236 to 37b2c93 Compare October 8, 2024 20:29
@AsherJingkongChen AsherJingkongChen changed the title [naga] Implement atomicCompareExchangeWeak for MSL backend [naga msl-out] Implement atomicCompareExchangeWeak for MSL backend Oct 8, 2024
@AsherJingkongChen
Copy link
Contributor Author

@jimblandy I understand that @9291Sam opened another similar PR, but the progress seems a bit slow. Since this branch is for my own project, I was hoping for quicker updates. That's why I decided to contribute.

Oh, definitely. I think we should probably review this PR instead. I just wanted to have the linkage there so that people could find the relationship if they wanted.

@jimblandy I understand. Thank you.

Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@teoxoy
Copy link
Member

teoxoy commented Oct 10, 2024

@AsherJingkongChen this needs a rebase + updating the msl snapshots due to #6285.

@AsherJingkongChen AsherJingkongChen force-pushed the pr/naga/msl/atomic-compare-exchange branch from 37b2c93 to 31548e2 Compare October 10, 2024 10:17
@teoxoy teoxoy merged commit bf33e48 into gfx-rs:trunk Oct 10, 2024
27 checks passed
@AsherJingkongChen
Copy link
Contributor Author

AsherJingkongChen commented Oct 10, 2024

@teoxoy I had not squashed commits, would it matter? I see it was auto-squashed.

@teoxoy
Copy link
Member

teoxoy commented Oct 10, 2024

I squashed them when I merged the PR (see bf33e48).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[msl-out] atomic CompareExchange is not implemented
3 participants