-
Notifications
You must be signed in to change notification settings - Fork 939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ray Queries #6291
Ray Queries #6291
Conversation
# Conflicts: # wgpu-core/src/binding_model.rs # wgpu-core/src/device/resource.rs # wgpu-hal/examples/ray-traced-triangle/main.rs # wgpu-hal/src/dx11/command.rs # wgpu-hal/src/dx11/device.rs # wgpu-hal/src/dx11/mod.rs # wgpu-hal/src/lib.rs # wgpu-types/src/lib.rs
upgrade
merge with gfx wgpu again
get up to latest
…cing-new # Conflicts: # wgpu-core/src/device/resource.rs # wgpu-core/src/hub.rs
I have noticed that quite a few resources use snatchables and it seems that they are used in resource destruction if the resource is in something such as a bind group, I will implement snatch guards for BLASes and TLASes while @cwfitzgerald works on moving the validation away from a mutable state on the BLAS/TLAS. |
@cwfitzgerald you were working on moving the validation away from a mutable state on the BLAS/TLAS, do you know how long that might take? It seems that other people are working off this branch (for example: #1040 (comment)), so it would be useful to get this branch into trunk. |
I coincidentally had just asked @cwfitzgerald about this on matrix. Posted their response below, with the first part paraphrased.
So sounds like we can merge once you rename the feature flag :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good after failing CI fixed
Thanks so much @Vecvec! What a great birthday present ❤️ |
I noticed that this PR makes use of |
|
I put up a PR with these changes ^. Could someone test it? |
Connections
Works towards #1040
Description
This PR provides BLASes (bottom level acceleration structures), TLASes (top level acceleration structures), TLAS instances (which contain BLASes and data, like transforms, about them), TLAS packages (which contain vectors of TLAS instances).
Testing
Running tests & examples included in PR
This a updated version of #3631 and is intended to replace it.
Checklist
cargo fmt
.cargo clippy
. If applicable, add:--target wasm32-unknown-unknown
--target wasm32-unknown-emscripten
cargo xtask test
to run tests.CHANGELOG.md
. See simple instructions inside file.Later (follow-up PR)
as_hal
methods