Add utils for WebGPU support detection & Instance creation #6371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarifies the docs on `wgpu::Instance` accordingly
Wumpf
force-pushed
the
better-webgpu-selection2
branch
from
9216f22 to
b77c64f
Compare
|
@rukai can you check if this solves the problem for you? I don't have a good repro setup for it right now |
teoxoy
reviewed
Oct 14, 2024
Co-authored-by: Teodor Tanasoaia <28601907+teoxoy@users.noreply.github.com>
|
Let's hold off with merging: Tried to test this myself now in Chromium on Wsl which seems to exhibit the issue, but I wasn't able to demonstrate it being fixed with using the new utility here |
|
phew! Figured it out quite quickly, |
|
I can confirm this successfully fixes webgl fallback on linux+chrome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Description
Targeting both WebGPU & WebGL at the same time works but is a pain right now. These new utilities and doc lines should make this a lot easier!
Would be nice to make use of this in the official examples, but don't quite know yet how - the examples on web today are geared towards explicit selection.
Testing
Testing done via https://github.com/Wumpf/minifb_wgpu_web_and_desktop/tree/better-webgpu-selection
navigator.gpunavigator.gpuno actual webgpu support (Chrome on Linux!)Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.