Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wgpu] Revert changes to vendored copy of web-sys from #6377. #6380

Merged

Conversation

jimblandy
Copy link
Member

Revert the changes to the vendored copy of web-sys's WebGPU bindings made in #6377. The only purpose of vendoring is to pin down our WebGPU JS bindings, not to allow local changes. And as it turns out, removing the max_inter_stage_shader_components accessor isn't necessary in order to fix #6290.

Revert the changes to the vendored copy of web-sys's WebGPU bindings
made in gfx-rs#6377. The only purpose of vendoring is to pin down our WebGPU
JS bindings, not to allow local changes. And as it turns out, removing
the `max_inter_stage_shader_components` accessor isn't necessary in
order to fix gfx-rs#6290.
@jimblandy jimblandy added the api: webgpu Issues with direct interface with WebGPU label Oct 8, 2024
@jimblandy jimblandy requested a review from a team as a code owner October 8, 2024 01:14
@jimblandy
Copy link
Member Author

cc @cwfitzgerald @grovesNL

@ErichDonGubler
Copy link
Member

Tested, and it works for me locally. Sorry for the confusion, @daxpedda, @gfx-rs/wgpu, @grovesNL!

@gfx-rs/wgpu: I think the combined change of this and #6377 could usefully be backported for whoever runs into this. What backporting range do y'all suggest? Perhaps at least 22.*?

@ErichDonGubler ErichDonGubler merged commit d70ef62 into gfx-rs:trunk Oct 10, 2024
27 checks passed
@ErichDonGubler ErichDonGubler added the PR: needs back-porting PR with a fix that needs to land on crates label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: webgpu Issues with direct interface with WebGPU PR: needs back-porting PR with a fix that needs to land on crates
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Remove SupportedLimits.maxInterStageShaderComponents
2 participants