Fix Vulkan surface capabilities being advertised when its query failed. #6510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
force-pushed
the
fix-vulkan-surface-cap-query
branch
from
24d95ce to
d1d1d38
Compare
7 tasks
Wumpf
force-pushed
the
fix-vulkan-surface-cap-query
branch
from
d1d1d38 to
4f39685
Compare
Wumpf
added a commit
that referenced
this pull request
Nov 23, 2024
Wumpf
added a commit
that referenced
this pull request
Nov 23, 2024
Wumpf
added a commit
that referenced
this pull request
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
I'm sure there's related tickets, but it's hard to dig up :/
Description
Observed in the wild Vulkan adapter gets chosen despite the surface being not compatible (e.g. causing a Vulkan adapter to be chosen over a working GL adapter). This happend because Vulkan backend violated the contract of returning usable surface configs.
Extending
GetSurfaceSupportErroris somewhat unrelated. More of a desperate attempt to output more information.Testing
I unfortunately don't have a repro case for any of these failures.
Checklist
cargo fmt.taplo format.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.