Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump metal #6592

Merged
merged 1 commit into from
Nov 23, 2024
Merged

bump metal #6592

merged 1 commit into from
Nov 23, 2024

Conversation

atlv24
Copy link
Contributor

@atlv24 atlv24 commented Nov 22, 2024 •
edited
Loading

Connections
#5537

Description
need metal shader atomic texture flag

Testing
cargo xtask test

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@atlv24 atlv24 requested a review from a team as a code owner November 22, 2024 23:53
cwfitzgerald
cwfitzgerald reviewed Nov 23, 2024
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the trickiest PR's I've ever reviewed 😛

Thanks!

@cwfitzgerald cwfitzgerald merged commit e05e46c into gfx-rs:trunk Nov 23, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwfitzgerald cwfitzgerald cwfitzgerald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atlv24 @cwfitzgerald