Backport #6994 to the 24.x branch #7169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErichDonGubler
approved these changes
Feb 17, 2025
|
I won't promise to do a release myself, but review 👍🏻 I can do! |
ErichDonGubler
added
the
area: ecosystem
|
Just noting, we've resolved in our maintainership meeting to remove the limit change from this to prevent it being a breaking change. I will do this change when I release the patch. |
| @@ -47,6 +47,7 @@ Bottom level categories: | |||
| * Fix `wgpu` not building with `--no-default-features` on when targeting `wasm32-unknown-unknown`. By @wumpf in [#6946](https://github.com/gfx-rs/wgpu/pull/6946). | |||
| * Implement `Clone` on `ShaderModule`. By @a1phyr in [#6937](https://github.com/gfx-rs/wgpu/pull/6937). | |||
| - Fix `CopyExternalImageDestInfo` not exported on `wgpu`. By @wumpf in [#6962](https://github.com/gfx-rs/wgpu/pull/6962). | |||
| - Reduce downlevel `max_color_attachments` limit from 8 to 4 for better GLES compatibility. By @adrian17 in [#6994](https://github.com/gfx-rs/wgpu/pull/6994). | |||
There was a problem hiding this comment.
This is in the wrong section. I will fix this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would let us avoid having to switch to our fork with the backport applied over at ruffle-rs/ruffle#19512, and then inevitably back to mainline when 25.0 comes out.
Just in case you would consider putting out a patch release for the 24.x series soon(er than 25.0 is ready)...
I don't know how much work that entails, and how much capacity you have for it, but thanks anyway!