Skip to content

Conversation

@ErichDonGubler
Copy link
Member

@ErichDonGubler ErichDonGubler commented Jun 13, 2025

This shortens clone times from minutes on my mediocre connection in Japan to about 10 seconds.

@ErichDonGubler ErichDonGubler requested a review from a team as a code owner June 13, 2025 05:27
@ErichDonGubler ErichDonGubler added area: performance How fast things go area: infrastructure Testing, building, coordinating issues area: cts Issues stemming from the WebGPU Conformance Test Suite labels Jun 13, 2025
@ErichDonGubler
Copy link
Member Author

@andyleiserson might find this particularly interesting.

Copy link
Contributor

@andyleiserson andyleiserson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you. I thought about this when I was working on it but I got the mistaken impression that shallow clone wouldn't work reliably for SHAs.

@andyleiserson
Copy link
Contributor

It looks like the --revision option is brand new in git 2.49. So it might be nice to fall back on a different way of cloning if that's not available.

@ErichDonGubler
Copy link
Member Author

Just pushed up a revision that naively queries the Git CLI when doing a check. If we need to do more than one of these, we might want to cache the version, but I didn't try to take that on yet.

@andyleiserson
Copy link
Contributor

Awesome, thanks!

@andyleiserson andyleiserson merged commit 371c8fd into gfx-rs:trunk Jun 16, 2025
40 checks passed
jamienicol added a commit to jamienicol/wgpu that referenced this pull request Jun 17, 2025
Git for Windows adds an extra suffix to the version string. This is a
follow up to gfx-rs#7800 that ensures we parse such git versions correctly
rather than returning an error.
@ErichDonGubler ErichDonGubler deleted the shallow-cts branch June 17, 2025 12:23
ErichDonGubler pushed a commit that referenced this pull request Jun 17, 2025
Git for Windows adds an extra suffix to the version string. This is a
follow up to #7800 that ensures we parse such git versions correctly
rather than returning an error.
sharmajai pushed a commit to sharmajai/wgpu that referenced this pull request Oct 12, 2025
sharmajai pushed a commit to sharmajai/wgpu that referenced this pull request Oct 12, 2025
Git for Windows adds an extra suffix to the version string. This is a
follow up to gfx-rs#7800 that ensures we parse such git versions correctly
rather than returning an error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: cts Issues stemming from the WebGPU Conformance Test Suite area: infrastructure Testing, building, coordinating issues area: performance How fast things go

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants