-
Notifications
You must be signed in to change notification settings - Fork 1.1k
chore(cts): clone CTS only shallowly #7800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(cts): clone CTS only shallowly #7800
Conversation
|
@andyleiserson might find this particularly interesting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, thank you. I thought about this when I was working on it but I got the mistaken impression that shallow clone wouldn't work reliably for SHAs.
|
It looks like the |
308e06b to
221411f
Compare
|
Just pushed up a revision that naively queries the Git CLI when doing a check. If we need to do more than one of these, we might want to cache the version, but I didn't try to take that on yet. |
|
Awesome, thanks! |
Git for Windows adds an extra suffix to the version string. This is a follow up to gfx-rs#7800 that ensures we parse such git versions correctly rather than returning an error.
Git for Windows adds an extra suffix to the version string. This is a follow up to #7800 that ensures we parse such git versions correctly rather than returning an error.
Git for Windows adds an extra suffix to the version string. This is a follow up to gfx-rs#7800 that ensures we parse such git versions correctly rather than returning an error.
This shortens clone times from minutes on my mediocre connection in Japan to about 10 seconds.