Add Jinja template support #11016

ochafik · 2024-12-30T03:48:15Z

Subset of #9639 with just the Jinja templating support.

Proper tool support (grammar constraints, lazy grammar triggering, tool call parsing & stop reason) will come in a follow up PR.

Copies minja.hpp & chat-template.hpp from google/minja (created for this 😅) at this commit
Adds --jinja flag to llama-server, llama-cli, llama-run
Adds --chat-template-file flag to llama-server, llama-cli (related: Added chat template support to llama-run #11215 )
Loads tokenizer.chat_template (or tokenizer.chat_template.tool_use if defined, only when the request has tools).
Dual testing in test-chat-template.cpp of legacy adhoc templating & jinja route. Wherever the expected outputs diverge, the jinja expectations should be more correct (note that templates are run w/ trim_blocks = true, lstrip_blocks = true)
- Sent Refactor test-chat-template.cpp #11224 separately

Example usage:

# Launch in background
./build/bin/llama-server \
  -hfr bartowski/Qwen2.5-7B-Instruct-GGUF \
  -hff Qwen2.5-7B-Instruct-Q4_K_M.gguf \
  --jinja &

curl http://localhost:8080/v1/chat/completions \
  -d '{
    "model": "gpt-3.5-turbo",
    "tools": [
      {
        "type": "function",
        "function": {
          "name": "ipython",
          "description": "Runs code in an ipython interpreter and returns the result of the execution after 60 seconds.",
          "parameters": {
            "type": "object",
            "properties": {
              "code": {
                "type": "string",
                "description": "The code to run in the ipython interpreter."
              }
            },
            "required": ["code"]
          }
        }
      }
    ],
    "messages": [
      {
        "role": "user",
        "content": "Print a hello world message with python (using single quotes '"'"' for strings)."
      }
    ]
  }'

show output

{
  "choices": [
    {
      "finish_reason": "stop",
      "index": 0,
      "message": {
        "content": "<tool_call>\n{\"name\": \"ipython\", \"arguments\": {\"code\": \"print('Hello world!')\"}}\n</tool_call>",
        "role": "assistant"
      }
    }
  ],
  "created": 1736811609,
  "model": "gpt-3.5-turbo",
  "system_fingerprint": "b4494-a57bb94e",
  "object": "chat.completion",
  "usage": {
    "completion_tokens": 25,
    "prompt_tokens": 205,
    "total_tokens": 230
  },
  "id": "chatcmpl-5YJXFVhvjoMDlLx1asuWNdSO3JVWWsUF",
  "timings": {
    "prompt_n": 1,
    "prompt_ms": 155.151,
    "prompt_per_token_ms": 155.151,
    "prompt_per_second": 6.445333900522716,
    "predicted_n": 25,
    "predicted_ms": 419.714,
    "predicted_per_token_ms": 16.78856,
    "predicted_per_second": 59.56437002339688
  }
}

TODO:

Add cross-testing in test-chat-template.cpp (note that minja is tested against a lot of templates in its own repo)
Add some instructions here
Add more server tests to exercise the template overrides.

ericcurtin · 2025-01-13T17:23:33Z

Feel free to add the option to llama-run for basic testing also @ochafik

common/arg.cpp

ngxson · 2025-01-20T21:50:20Z

common/chat-template.hpp

+
+namespace minja {
+
+class chat_template {


One idea to be able to #include "chat-template.hpp" in main is to forward declare json here without #include <json.hpp>, only define the prototype of class chat_template here. Then we will need a new file chat-template.cpp that hold the actual implementation, including #include <json.hpp>

(Not sure if this even works, but we can do in another PR, just noting my idea here)

I was hoping to keep minja header-only for now, but happy to explore options as follow up :-)

ngxson

Impressive work, thanks! Let's wait for @ggerganov to do another pass, then I think it's good to go!

ngxson · 2025-01-20T22:14:34Z

examples/server/tests/unit/test_chat_completion.py

@@ -4,22 +4,26 @@

 server = ServerPreset.tinyllama2()

-
-@pytest.fixture(scope="module", autouse=True)
+@pytest.fixture(autouse=True)


I'm not exceptionally good at pytest so maybe I'm missing something. Could you explain why scope="module" is removed here?

scope=module was making the ServerProcess server instance shared between all the test in the module (file). Even though it's stopped in stop_server_after_each_test, it carried previous settings over to subsequent tests, spilling server flags over (became more important w/ jinja & chat_template params)

Ok thanks for the explanation. Seem like module=scope is not what I wanted. I want the fixture to only affect single file, since the idea is that one test unit uses one model

ngxson · 2025-01-20T22:16:40Z

examples/server/tests/unit/test_chat_completion.py

    ]
 )
-def test_chat_completion(model, system_prompt, user_prompt, max_tokens, re_content, n_prompt, n_predicted, finish_reason):
+def test_chat_completion(model, system_prompt, user_prompt, max_tokens, re_content, n_prompt, n_predicted, finish_reason, jinja, chat_template):


TODO: we can also add a "slow" test that can test tool call with a big model like Hermes or Qwen (see an example in test_infill.py). I'll have a look in the next few days.

hehe absolutely, this is coming in #9639 or another subpart of it (tool call parsing + conditional grammars)

https://github.com/ochafik/llama.cpp/blob/76893f588019ba09c5f4726a97994ffac91ecf34/examples/server/tests/unit/test_chat_completion.py#L300

btw I wonder if there's any reason to override the LLAMA_CACHE to tmp in server tests? I've been struggling with disk space on my MBP 😅

It's mostly to provide a way to isolate tests if user have multiple clones of llama.cpp source code on the machine. Maybe you can symlink that tmp directory to an external storage ?

…llama_vocab::impl::token_get_attr)

…them

slaren · 2025-01-21T02:11:26Z

common/minja.hpp

+static std::string normalize_newlines(const std::string & s) {
+#ifdef _WIN32
+  static const std::regex nl_regex("\r\n");
+  return std::regex_replace(s, nl_regex, "\n");
+#else
+  return s;
+#endif
+}


Not sure what was the original purpose for this, but I think it can be removed, as well as the definition of ENDL to \r\n in win32. It shouldn't make a difference with stringstream.

Dropped ENDL + 1 usage of this function (at end of rendering; one is still needed to shield the parser from CRLFs), thanks!

examples/server/server.cpp

ngxson · 2025-01-21T09:19:36Z

Small thing to note is that some jinja templates are not "linear", meaning each conversation turn is not self-contained, but can modify the content before it.

For example, the new deepseek-r1 distilled has {% set content = content.split('</think>')[-1] %} to remove the thinking process from conversation history. I also once saw a template that adds EOS token after each formatted chat, which also breaks this logic.

The consequence is that it will break common_chat_format_single (used in llama-cli) and apply_chat_template (used by llama-run) since they assume that each new message is self-contained (i.e. is addition, but not modification)

A solution is to also track the cached token at token level (not conversation level), which I introduced here #11203 , @ericcurtin feel free to port this to llama-run if you want. This approach is kinda like server implementation.

ochafik · 2025-01-21T14:05:35Z

Thanks everyone for the insightful reviews! More from #9639 to come soon :-)

fairydreaming · 2025-01-21T18:23:49Z

Not sure if this is a special case or the template is broken, but when I load minimax-text-01 (my work-in-progress) with the following template:

{% for message in messages %}{% if message['role'] == 'system' %}{{ '<beginning_of_sentence>system ai_setting=assistant\\n' + message['content'][0]['text'] + '<end_of_sentence>\\n'}}{% elif message['role'] == 'user' %}{{ '<beginning_of_sentence>user name=user\\n' + message['content'][0]['text'] + '<end_of_sentence>\\n'}}{% elif message['role'] == 'assistant' %}{{ '<beginning_of_sentence>ai name=assistant\\n' }}{% for content in message['content'] | selectattr('type', 'equalto', 'text') %}{% generation %}{{ content['text'] }}{% endgeneration %}{% endfor %}{{ '<end_of_sentence>\\n' }}{% endif %}{% endfor %}{% if add_generation_prompt %}{{ '<beginning_of_sentence>ai name=assistant\\n' }}{% endif %}

with this PR llama.cpp crashes during model loading:

terminate called after throwing an instance of 'std::runtime_error'
  what():  Expected block keyword at row 1, column 492:
{% for message in messages %}{% if message['role'] == 'system' %}{{ '<beginning_of_sentence>system ai_setting=assistant\n' + message['content'][0]['text'] + '<end_of_sentence>\n'}}{% elif message['role'] == 'user' %}{{ '<beginning_of_sentence>user name=user\n' + message['content'][0]['text'] + '<end_of_sentence>\n'}}{% elif message['role'] == 'assistant' %}{{ '<beginning_of_sentence>ai name=assistant\n' }}{% for content in message['content'] | selectattr('type', 'equalto', 'text') %}{% generation %}{{ content['text'] }}{% endgeneration %}{% endfor %}{{ '<end_of_sentence>\n' }}{% endif %}{% endfor %}{% if add_generation_prompt %}{{ '<beginning_of_sentence>ai name=assistant\n' }}{% endif %}
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                           ^

ochafik · 2025-01-21T18:33:38Z

Not sure if this is a special case or the template is broken, but when I load minimax-text-01 (my work-in-progress) with the following template:

{% for message in messages %}{% if message['role'] == 'system' %}{{ '<beginning_of_sentence>system ai_setting=assistant\\n' + message['content'][0]['text'] + '<end_of_sentence>\\n'}}{% elif message['role'] == 'user' %}{{ '<beginning_of_sentence>user name=user\\n' + message['content'][0]['text'] + '<end_of_sentence>\\n'}}{% elif message['role'] == 'assistant' %}{{ '<beginning_of_sentence>ai name=assistant\\n' }}{% for content in message['content'] | selectattr('type', 'equalto', 'text') %}{% generation %}{{ content['text'] }}{% endgeneration %}{% endfor %}{{ '<end_of_sentence>\\n' }}{% endif %}{% endfor %}{% if add_generation_prompt %}{{ '<beginning_of_sentence>ai name=assistant\\n' }}{% endif %}

Hey @fairydreaming , thanks for testing & reporting! Your template contain an exotic {% generation %}...{% endgeneration %} syntax that doesn't seem supported by, say, this online jinja parser either.

terminate called after throwing an instance of 'std::runtime_error'
what(): Expected block keyword at row 1, column 492:

I could certainly make the error more informative though, feel free to file something on https://github.com/google/minja to that end (and/or any feature request).

Looking forward to testing your model, good luck with it!

fairydreaming · 2025-01-21T19:06:08Z

@ochafik I did some research and it seems to be a custom keyword introduced in HF transformers: huggingface/transformers#30650

Fortunately among all the models I have currently on disk only MiniMax-Text-01 uses this.

ochafik · 2025-01-22T03:00:09Z

@ochafik I did some research and it seems to be a custom keyword introduced in HF transformers: huggingface/transformers#30650

Fortunately among all the models I have currently on disk only MiniMax-Text-01 uses this.

@fairydreaming thanks for researching that, will track support in google/minja#28

github-actions bot added script Script related examples python python script changes server labels Dec 30, 2024

ochafik added 2 commits December 30, 2024 03:50

Copy minja from google/minja@58f0ca6

abd274a

Add --jinja and --chat-template-file flags

e5113e8

ochafik force-pushed the jinja branch from 4ec6151 to e5113e8 Compare December 30, 2024 03:50

ochafik added 4 commits December 30, 2024 04:10

Add missing <optional> include

80138d9

Avoid print in get_hf_chat_template.py

06b5159

No designated initializers yet

ce48584

Try and work around msvc++ non-macro max resolution quirk

389d79b

ochafik force-pushed the jinja branch from c3b07a8 to 389d79b Compare December 30, 2024 04:50

Update test_chat_completion.py

238b968

ochafik mentioned this pull request Dec 30, 2024

Tool call support (Llama 3.x, Functionary v3, Hermes 2 Pro, Mistral Nemo, generic) w/ lazy grammars #9639

Draft

35 tasks

slaren mentioned this pull request Dec 31, 2024

llama : add support for Cohere2ForCausalLM #10900

Merged

ngxson mentioned this pull request Jan 13, 2025

Added chat template support to llama-run #11215

Draft

ochafik added 4 commits January 13, 2025 19:56

Merge remote-tracking branch 'origin/master' into jinja

cb72cf1

Wire LLM_KV_TOKENIZER_CHAT_TEMPLATE_N in llama_model_chat_template

78861a3

Refactor test-chat-template

1aac99a

Test templates w/ minja

7c84ebc

github-actions bot added the testing Everything test related label Jan 13, 2025

ochafik added 8 commits January 13, 2025 21:30

Fix deprecation

18f257b

Add --jinja to llama-run

8dd4f33

Merge remote-tracking branch 'origin/master' into jinja

c04c50e

Update common_chat_format_example to use minja template wrapper

a6afb27

Test chat_template in e2e test

b4083e4

Update utils.py

b7e2171

Update test_chat_completion.py

a57bb94

Update run.cpp

4daae0b

Move chat_templates inside server_context + remove mutex

c9e8fdd

ngxson reviewed Jan 20, 2025

View reviewed changes

common/arg.cpp Outdated Show resolved Hide resolved

ngxson reviewed Jan 20, 2025

View reviewed changes

common/arg.cpp Outdated Show resolved Hide resolved

Update --chat-template-file w/ recent change to --chat-template

8c84aef

ngxson reviewed Jan 20, 2025

View reviewed changes

ochafik added 2 commits January 20, 2025 21:54

Refactor chat template validation

154bfaa

Merge remote-tracking branch 'origin/master' into jinja

099f983

ngxson approved these changes Jan 20, 2025

View reviewed changes

ochafik mentioned this pull request Jan 20, 2025

changelog : libllama API #9289

Open

ochafik added 6 commits January 20, 2025 22:50

Guard against missing eos/bos tokens (null token otherwise throws in …

54a669e

…llama_vocab::impl::token_get_attr)

Warn against missing eos / bos tokens when jinja template references …

8348c60

…them

rename: common_chat_template[s]

ee475d2

reinstate assert on chat_templates.template_default

8a7c89e

Update minja to google/minja@b8437df

8347da9

Update minja to google/minja#25

ff2cce5

slaren reviewed Jan 21, 2025

View reviewed changes

ochafik mentioned this pull request Jan 21, 2025

Drop ENDL macro google/minja#26

Merged

Update minja from google/minja#27

9d8ebd6

ggerganov approved these changes Jan 21, 2025

View reviewed changes

examples/server/server.cpp Outdated Show resolved Hide resolved

ngxson mentioned this pull request Jan 21, 2025

Eval bug: <think> tag with DeepSeek-R1-Distill-Qwen-1.5B-Q5_K_M.gguf #11325

Open

ochafik force-pushed the jinja branch from cec1ad7 to 9d8ebd6 Compare January 21, 2025 12:26

rm unused optional header

cbb9b81

ochafik merged commit 6171c9d into ggerganov:master Jan 21, 2025
47 checks passed

ochafik mentioned this pull request Jan 22, 2025

Support MiniMaxAI/MiniMax-Text-01 ({% generation %} blocks) google/minja#28

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Jinja template support #11016

Add Jinja template support #11016

ochafik commented Dec 30, 2024 •

edited

Loading

ericcurtin commented Jan 13, 2025

ngxson Jan 20, 2025

ngxson Jan 20, 2025

ochafik Jan 20, 2025

ngxson left a comment

ngxson Jan 20, 2025

ochafik Jan 20, 2025

ngxson Jan 21, 2025

ngxson Jan 20, 2025

ochafik Jan 20, 2025 •

edited

Loading

ochafik Jan 20, 2025

ngxson Jan 21, 2025

slaren Jan 21, 2025

ochafik Jan 21, 2025

ngxson commented Jan 21, 2025

ochafik commented Jan 21, 2025

fairydreaming commented Jan 21, 2025

ochafik commented Jan 21, 2025

fairydreaming commented Jan 21, 2025

ochafik commented Jan 22, 2025


		namespace minja {

		class chat_template {

Add Jinja template support #11016

Add Jinja template support #11016

Conversation

ochafik commented Dec 30, 2024 • edited Loading

ericcurtin commented Jan 13, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ngxson left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ochafik Jan 20, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ngxson commented Jan 21, 2025

ochafik commented Jan 21, 2025

fairydreaming commented Jan 21, 2025

ochafik commented Jan 21, 2025

fairydreaming commented Jan 21, 2025

ochafik commented Jan 22, 2025

ochafik commented Dec 30, 2024 •

edited

Loading

ochafik Jan 20, 2025 •

edited

Loading