Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BPE dropout support, use it in training. #2073

Closed
wants to merge 2 commits into from
Closed

Add BPE dropout support, use it in training. #2073

wants to merge 2 commits into from

Conversation

howard0su
Copy link
Collaborator

No description provided.

@howard0su
Copy link
Collaborator Author

I don't have hardware to run through training and validation. I just noticed this when I was reading BPE code for #2023

Green-Sky
Green-Sky reviewed Jul 2, 2023
View reviewed changes
llama.cpp Outdated Show resolved Hide resolved
llama.cpp Show resolved Hide resolved
@howard0su howard0su requested a review from Green-Sky July 3, 2023 11:59
@howard0su howard0su requested a review from ggerganov July 3, 2023 23:50
@howard0su
Copy link
Collaborator Author

Is it okay for me to add new parameter to tokenize API?

@mofosyne mofosyne added Review Complexity : Medium Generally require more time to grok but manageable by beginner to medium expertise level enhancement New feature or request labels May 14, 2024
@ggerganov ggerganov closed this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Green-Sky Green-Sky Green-Sky approved these changes

@ggerganov ggerganov Awaiting requested review from ggerganov

Assignees
No one assigned
Labels
enhancement New feature or request Review Complexity : Medium Generally require more time to grok but manageable by beginner to medium expertise level
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@howard0su @Green-Sky @mofosyne @ggerganov