build : on Mac OS enable Metal by default #2901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cebtenzzre
reviewed
Aug 30, 2023
cebtenzzre
reviewed
Aug 30, 2023
|
This is exciting. What about defaulting to appropriate -ngl as well? |
ggerganov
force-pushed
the
build-metal-default
branch
from
4e283c1
to
e966ae0
Compare
cebtenzzre
reviewed
Sep 1, 2023
ggerganov
force-pushed
the
build-metal-default
branch
from
a496f26
to
b59beeb
Compare
ggerganov
commented
Sep 3, 2023
|
With this change, we should use Metal by default on Mac OS - both |
cebtenzzre
reviewed
Sep 3, 2023
cebtenzzre
approved these changes
Sep 4, 2023
Closed
cebtenzzre
added a commit
to cebtenzzre/llama.cpp
that referenced
this pull request
Sep 7, 2023
This was broken by commit e36ecdc ("build : on Mac OS enable Metal by default (ggerganov#2901)").
cebtenzzre
added a commit
that referenced
this pull request
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.