Fix trying to strip newline from empty prompt and cfg prompt file content #3534
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the prompt or CFG negative prompt file options are set to an empty file, attempting to strip a newline currently causes a memory error. This small fix just makes sure the files aren't empty. I found this out the fun way (don't ask why I set
-f /dev/null
).Also, GCC's address sanitizer is pretty handy. Maybe there should be a
LLAMA_ADDRESS_SANITIZER
option that just adds-fsanitize=address -g
to theCFLAGS
andCXXFLAGS
. I believe this will work with Clang also. It even seems to work when compiling with optimizations turned on and is way faster than Valgrind.