CLBlast: Fix matrix-vector multiplication #3544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggerganov
approved these changes
Oct 8, 2023
|
Thank you for your work. I didn't notice any issues and it ran fine. Can you tell me the case where the implementation in master fails, that is solved by this fix? |
|
For f16, q4_0, q4_1, q5_0, q5_1, q8_0: it can go beyond actual data and add extra values. When 3D or 4D src0 was uploaded with |
|
Alright, thank you. |
joelkuiper
added a commit
to vortext/llama.cpp
that referenced
this pull request
Oct 13, 2023
* 'master' of github.com:joelkuiper/llama.cpp: CLBlast: Fix matrix-vector multiplication (ggerganov#3544)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix computation for non-K quantized src0.
Add offsets into previously uploaded data, similar to #3447.
Broadcasting (#3402) works in cases affected by this change.
Tested in isolation and with few models.