-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix gguf-convert-endian script #4037
Conversation
cc @chenqiny |
It's resolved. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, thanks for fixing that! I guess I messed it up when refactored those scripts to work with the Poetry package stuff.
All those linters and type checkers can catch the tiniest discrepancy in whitespace or whatever but can't warn me about something that simple and dumb? :(
mypy and pytype aren't so good with unbound variables, but pyright can catch them (and there may be a flake8 plugin that can do it too). It's not my favorite because it has a lot of false positives.
|
I tested it with new generated llama2 7b model with convert.py and llama2 7b converted from convert script. |
Are you letting the suspense build before you tell us whether the result of testing was success or failure? :) I'm on the edge of my seat! 或者说我都迫不及待啦! |
I just built it with the pull request. |
* Fix gguf-convert-endian script * Bump version and update description
Reported in this issue comment