Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update install make by w64devkit #5297

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

NeoZhangJianyu
Copy link
Collaborator

add install make.exe method in windows by w64devkit.

@NeoZhangJianyu
Copy link
Collaborator Author

@airMeng , @luoyu-intel @abhilash1910 @cebtenzzre
Invite you to review.

Copy link
Collaborator

@airMeng airMeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can simply as the main README.md does

- On Windows:

@NeoZhangJianyu
Copy link
Collaborator Author

maybe we can simply as the main README.md does

- On Windows:

The usage in the guide of README.md is to build the whole project in shell (unix-like) environment. I try it and its fault (cmake issue, maybe cmake conflict to other cmake in my PC).
Here, we just use the make.exe for windows native build (windows command line).

- Unzip the binary package. In the **bin** sub-folder and rename **xxx-make.exe** to **make.exe**.

- Add the **bin** folder path in the Windows system PATH environment.
- Add the **bin** folder path in the Windows system PATH environment, like `C:\xxx\w64devkit\bin\`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason the w64devkit console can't be used for the following steps, instead of polluting the native Windows environment with Unix-like build tools?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried with w64devkit console. The compile is fault now. cmake report issue.
So I introduce native windows environment.

I'm busy for another feature development now. I will check it later.

@airMeng airMeng merged commit 10afa6f into ggerganov:master Feb 7, 2024
21 checks passed
jordankanter pushed a commit to jordankanter/llama.cpp that referenced this pull request Mar 13, 2024
hodlen pushed a commit to hodlen/llama.cpp that referenced this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants