-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
code : normalize enum names #5697
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggml-ci
slaren
approved these changes
Feb 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I would prefer to do it the other way around, and remove all the _TYPE
_NAME
_MODE
etc suffixes from the enum values, but ultimately I think that the most important is to be consistent with the style.
jordankanter
pushed a commit
to jordankanter/llama.cpp
that referenced
this pull request
Mar 13, 2024
* coda : normalize enum names ggml-ci * code : cont * code : cont
hodlen
pushed a commit
to hodlen/llama.cpp
that referenced
this pull request
Apr 1, 2024
* coda : normalize enum names ggml-ci * code : cont * code : cont
kou
added a commit
to kou/llama.cpp
that referenced
this pull request
Aug 16, 2024
LLAMA_SPLIT_* were renamed to LLAMA_SPLIT_MODE_* in ggerganov#5697.
kou
added a commit
to kou/llama.cpp
that referenced
this pull request
Aug 16, 2024
LLAMA_SPLIT_* were renamed to LLAMA_SPLIT_MODE_* in ggerganov#5697.
4 tasks
slaren
pushed a commit
that referenced
this pull request
Aug 30, 2024
LLAMA_SPLIT_* were renamed to LLAMA_SPLIT_MODE_* in #5697.
dsx1986
pushed a commit
to dsx1986/llama.cpp
that referenced
this pull request
Oct 29, 2024
…nov#9057) LLAMA_SPLIT_* were renamed to LLAMA_SPLIT_MODE_* in ggerganov#5697.
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Nov 15, 2024
…nov#9057) LLAMA_SPLIT_* were renamed to LLAMA_SPLIT_MODE_* in ggerganov#5697.
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Nov 18, 2024
…nov#9057) LLAMA_SPLIT_* were renamed to LLAMA_SPLIT_MODE_* in ggerganov#5697.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed we haven't been very consistent with naming the enums. For example:
With this PR, I propose that we always follow the convention to suffix the full enum name:
Is this change worth it? It touches a lot of lines