Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: server: verify deps are coherent with the commit #6409

Merged
merged 2 commits into from
Apr 1, 2024

Conversation

phymbert
Copy link
Collaborator

@phymbert phymbert commented Mar 31, 2024

Context

It can be difficult to assess if the server dependencies are built correctly, as the files are obsucated, example:

Changes

  • Run in the server CI workflow the deps.sh and verify the git index is not dirty.
  • Do not allow to change the server CI workflow from a fork branch
  • Change the schedule trigger to a time where github runners should be less busy
  • include any files modified in the server as trigger

Tests

@phymbert phymbert force-pushed the hp/server/deps-check branch from 09f24c2 to 561c8b8 Compare March 31, 2024 14:06
@phymbert phymbert marked this pull request as ready for review April 1, 2024 06:23
@phymbert phymbert requested a review from ggerganov April 1, 2024 06:23
@phymbert phymbert merged commit 226e819 into master Apr 1, 2024
13 checks passed
@phymbert phymbert deleted the hp/server/deps-check branch April 1, 2024 10:36
hodlen pushed a commit to hodlen/llama.cpp that referenced this pull request Apr 1, 2024
* ci: server: verify deps are coherent with the commit

* ci: server: change the ref to build as now it's a pull event target
hodlen pushed a commit to hodlen/llama.cpp that referenced this pull request Apr 3, 2024
* ci: server: verify deps are coherent with the commit

* ci: server: change the ref to build as now it's a pull event target
tybalex pushed a commit to rubra-ai/tools.cpp that referenced this pull request Apr 17, 2024
* ci: server: verify deps are coherent with the commit

* ci: server: change the ref to build as now it's a pull event target
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants