Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL ]add build shared lib in win release package #7438

Merged
merged 1 commit into from
May 24, 2024

Conversation

arthw
Copy link
Collaborator

@arthw arthw commented May 21, 2024

add build shared lib (like llama.dll) in win release package

@arthw arthw requested a review from airMeng May 21, 2024 14:32
@mofosyne mofosyne added build Compilation issues Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix labels May 21, 2024
Copy link
Collaborator

@airMeng airMeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why put it as default behavior?

cc @zhewang1-intc

@gfody
Copy link

gfody commented May 22, 2024

why put it as default behavior?

the other release packages contain llama.dll (and this makes them convenient to use them with LLamaSharp) so I thought it was unexpected that it's missing from the sycl package and opened #7361

@NeoZhangJianyu
Copy link
Collaborator

why put it as default behavior?

cc @zhewang1-intc

The windows release package is used to direct user or developer who call llama.dll in other project.
I receive an issue to ask to add it: #7361.

@airMeng airMeng merged commit 0df0aa8 into ggerganov:master May 24, 2024
11 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Compilation issues examples Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants