Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing macro definitions #8281

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

akemimadoka
Copy link
Contributor

The macros GGML_SHARED and GGML_BUILD are missing for ggml project
Without these macros, while building ggml as DLL on Windows, linking ggml to llama will fail with error LNK2019

Nexesenex added a commit to Nexesenex/croco.cpp that referenced this pull request Jul 3, 2024
Integrate it in comments for now

Co-Authored-By: Natsu <chino@hotococoa.moe>
Nexesenex added a commit to Nexesenex/croco.cpp that referenced this pull request Jul 4, 2024
Integrate it in comments for now

Co-Authored-By: Natsu <chino@hotococoa.moe>
Nexesenex added a commit to Nexesenex/croco.cpp that referenced this pull request Jul 4, 2024
Integrate it in comments for now

Co-Authored-By: Natsu <chino@hotococoa.moe>
@ggerganov ggerganov merged commit 1d894a7 into ggerganov:master Jul 5, 2024
53 checks passed
Nexesenex added a commit to Nexesenex/croco.cpp that referenced this pull request Jul 6, 2024
Integrate it in comments for now

Co-Authored-By: Natsu <chino@hotococoa.moe>
Nexesenex pushed a commit to Nexesenex/croco.cpp that referenced this pull request Jul 8, 2024
Nexesenex added a commit to Nexesenex/croco.cpp that referenced this pull request Jul 11, 2024
Integrate it in comments for now

Co-Authored-By: Natsu <chino@hotococoa.moe>
Nexesenex pushed a commit to Nexesenex/croco.cpp that referenced this pull request Jul 11, 2024
Nexesenex pushed a commit to Nexesenex/croco.cpp that referenced this pull request Jul 11, 2024
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants