Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Safari Compatibility Issue: Replace URL.parse Method in llama-server UI #8646

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

0x4139
Copy link
Contributor

@0x4139 0x4139 commented Jul 23, 2024

The URL.parse method is not available in all browsers, particularly Safari, which causes the UI interface for llama-server to break. This pull request replaces the URL.parse method with the new URL() constructor to ensure compatibility across all browsers. Using new URL() provides a more standardized and widely supported way to parse URLs, resolving the issue with Safari and improving overall browser compatibility.

Fixes #8631

Copy link
Owner

@ggerganov ggerganov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think this is this related to #8631?

@0x4139
Copy link
Contributor Author

0x4139 commented Jul 23, 2024

Do you think this is this related to #8631?

Yes, one of the users mentions that the web UI works on chromium, so it's definitely a compatibility issue. It also seems that the bug was introduced in #8552

@ggerganov ggerganov merged commit b841d07 into ggerganov:master Jul 23, 2024
11 checks passed
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: server is broken by Mistral Nemo commit
2 participants