[example] batched-bench "segmentation fault" #8839
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
llama-batched-bench
is invoked without setting-npl
, "number of parallel prompts", it segfaults.The segfault is caused by invoking
max_element()
on a zero-length vector,n_pl
.This commit addresses that by first checking to see if the number of parallel prompts is zero, and if so sets the maximum sequence size to 1; otherwise, sets it to the original, the result of
max_element()
.Fixes, when running
lldb build/bin/llama-batched-bench -- -m models/Meta-Llama-3-8B.gguf
Thank you all for your good work — I love
llama.cpp
!