Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common : restore --n-gpu-layers #9371

Merged
merged 1 commit into from
Sep 8, 2024
Merged

common : restore --n-gpu-layers #9371

merged 1 commit into from
Sep 8, 2024

Conversation

slaren
Copy link
Collaborator

@slaren slaren commented Sep 8, 2024

This commonly used variation of the command line argument was removed in #9308.

@slaren slaren requested a review from ngxson September 8, 2024 13:08
Copy link
Collaborator

@ngxson ngxson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

FYI part of my code in #9308 was auto-migrated using a script. Since it takes gpt_params_print_usage as reference, some arguments maybe missed. I'll do another pass to make sure no args is dropped.

@ngxson ngxson merged commit a249843 into master Sep 8, 2024
53 checks passed
@slaren slaren deleted the sl/fix-ngl-arg branch September 8, 2024 14:45
dsx1986 pushed a commit to dsx1986/llama.cpp that referenced this pull request Oct 29, 2024
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Nov 15, 2024
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants