Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed RNG seed docs #9723

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Fixed RNG seed docs #9723

merged 2 commits into from
Oct 4, 2024

Conversation

d-kleine
Copy link
Contributor

@d-kleine d-kleine commented Oct 3, 2024 •
edited
Loading

  • fix: set default RNG seed info in README to be random (-1)
  • fix: changed format for --seed that it prints signed (-1)

RNG seed (LLAMA_DEFAULT_SEED)

#define LLAMA_DEFAULT_SEED 0xFFFFFFFF

0xFFFFFFFF equals -1

@d-kleine
Update README.md
c6f4c22 
fixed RNG seed info
@ngxson
Copy link
Collaborator

ngxson commented Oct 3, 2024

This help section is generated from llama-server -h, so it's better to modify in arg.cpp too

@d-kleine d-kleine marked this pull request as draft October 3, 2024 20:42
@d-kleine d-kleine changed the title Fixed RNG seed info in README Fixed RNG seed docs Oct 3, 2024
@d-kleine d-kleine marked this pull request as ready for review October 3, 2024 21:02
@ngxson ngxson merged commit 133c7b4 into ggerganov:master Oct 4, 2024
53 checks passed
dsx1986 pushed a commit to dsx1986/llama.cpp that referenced this pull request Oct 29, 2024
@d-kleine @dsx1986
Fixed RNG seed docs (ggerganov#9723)
7a899ab 
* Update README.md

fixed RNG seed info

* changed print format to unsigned
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Nov 15, 2024
@d-kleine @arthw
Fixed RNG seed docs (ggerganov#9723)
1f55070 
* Update README.md

fixed RNG seed info

* changed print format to unsigned
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Nov 18, 2024
@d-kleine @arthw
Fixed RNG seed docs (ggerganov#9723)
0ea000d 
* Update README.md

fixed RNG seed info

* changed print format to unsigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngxson ngxson ngxson approved these changes

Assignees
No one assigned
Labels
examples server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d-kleine @ngxson