Fixing Accidental 'exit(0)' and Ensuring Proper 'return 1' in examples/main/main.cpp whisper_params_parse
#1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faker2048
changed the title
examples/main/main.cpp whisper_params_parse examples/main/main.cpp whisper_params_parse correctly returns false
faker2048
changed the title
examples/main/main.cpp whisper_params_parse correctly returns falseexamples/main/main.cpp whisper_params_parse
ggerganov
approved these changes
Jun 25, 2023
winning1120xx
pushed a commit
to winning1120xx/whisper.cpp
that referenced
this pull request
Jun 25, 2023
* Refactor whisper_params_parse to return false on failure * Updated help flag behavior
jacobwu-b
pushed a commit
to jacobwu-b/Transcriptify-by-whisper.cpp
that referenced
this pull request
Oct 24, 2023
* Refactor whisper_params_parse to return false on failure * Updated help flag behavior
jacobwu-b
pushed a commit
to jacobwu-b/Transcriptify-by-whisper.cpp
that referenced
this pull request
Oct 24, 2023
* Refactor whisper_params_parse to return false on failure * Updated help flag behavior
landtanin
pushed a commit
to landtanin/whisper.cpp
that referenced
this pull request
Dec 16, 2023
* Refactor whisper_params_parse to return false on failure * Updated help flag behavior
iThalay
pushed a commit
to iThalay/whisper.cpp
that referenced
this pull request
Sep 23, 2024
* Refactor whisper_params_parse to return false on failure * Updated help flag behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix what appears to be an inadvertent mistake of 'exit(0)'. It should likely return 'false' here to remain consistent with the following code, otherwise the program will never return '1', making the 'if' statement on line 691 meaningless.