Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go bindings: fix context.Process call in examples #1067

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

mvrilo
Copy link
Contributor

@mvrilo mvrilo commented Jun 29, 2023

context.Process now expects 2 callbacks:

https://github.com/ggerganov/whisper.cpp/blob/master/bindings/go/pkg/whisper/interface.go#L54
https://github.com/ggerganov/whisper.cpp/blob/master/bindings/go/pkg/whisper/context.go#L155-L158

The error:

~/Development/whisper.cpp/bindings/go $ make                                                                                                                                              (base)
Clean
Mkdir build
Mkdir models
Build whisper
I whisper.cpp build info:
I UNAME_S:  Darwin
I UNAME_P:  arm
I UNAME_M:  arm64
I CFLAGS:   -I.              -O3 -DNDEBUG -std=c11   -fPIC -D_XOPEN_SOURCE=600 -D_DARWIN_C_SOURCE -pthread -DGGML_USE_ACCELERATE
I CXXFLAGS: -I. -I./examples -O3 -DNDEBUG -std=c++11 -fPIC -D_XOPEN_SOURCE=600 -D_DARWIN_C_SOURCE -pthread
I LDFLAGS:   -framework Accelerate
I CC:       Apple clang version 14.0.3 (clang-1403.0.22.14.1)
I CXX:      Apple clang version 14.0.3 (clang-1403.0.22.14.1)

make[1]: `libwhisper.a' is up to date.
Build example go-model-download
Build example go-whisper
# github.com/ggerganov/whisper.cpp/bindings/go/examples/go-whisper
examples/go-whisper/process.go:70:34: not enough arguments in call to context.Process
        have ([]float32, "github.com/ggerganov/whisper.cpp/bindings/go/pkg/whisper".SegmentCallback)
        want ([]float32, "github.com/ggerganov/whisper.cpp/bindings/go/pkg/whisper".SegmentCallback, "github.com/ggerganov/whisper.cpp/bindings/go/pkg/whisper".ProgressCallback)
make: *** [examples/go-whisper] Error 1

@ggerganov ggerganov merged commit 66616db into ggerganov:master Jul 4, 2023
jacobwu-b pushed a commit to jacobwu-b/Transcriptify-by-whisper.cpp that referenced this pull request Oct 24, 2023
jacobwu-b pushed a commit to jacobwu-b/Transcriptify-by-whisper.cpp that referenced this pull request Oct 24, 2023
landtanin pushed a commit to landtanin/whisper.cpp that referenced this pull request Dec 16, 2023
iThalay pushed a commit to iThalay/whisper.cpp that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants