Minor fixes #1154
Merged
Minor fixes #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobqianic
reviewed
Aug 22, 2023
| @@ -82,7 +82,7 @@ static void byteswap_tensor(ggml_tensor * tensor) { | |||
| } while (0) | |||
| #define BYTESWAP_TENSOR(t) \ | |||
| do { \ | |||
| byteswap_tensor(tensor); \ | |||
| byteswap_tensor(t); \ | |||
There was a problem hiding this comment.
Could you clarify what issues this is causing? And why do we need to switch from tensor to t?
There was a problem hiding this comment.
-
The current implementation is misleading. The macro accepts an argument, but it is never used.
-
It has not caused errors so far because the place where the macro is used exists a variable with name 'tensor'. Had you changed the variable name, would the code be broken.
ggerganov
approved these changes
Aug 27, 2023
jacobwu-b
pushed a commit
to jacobwu-b/Transcriptify-by-whisper.cpp
that referenced
this pull request
Oct 24, 2023
jacobwu-b
pushed a commit
to jacobwu-b/Transcriptify-by-whisper.cpp
that referenced
this pull request
Oct 24, 2023
vonstring
pushed a commit
to vonstring/whisper.cpp
that referenced
this pull request
Nov 7, 2023
landtanin
pushed a commit
to landtanin/whisper.cpp
that referenced
this pull request
Dec 16, 2023
iThalay
pushed a commit
to iThalay/whisper.cpp
that referenced
this pull request
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.