Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes #1154

Merged
merged 1 commit into from
Aug 27, 2023
Merged

Minor fixes #1154

merged 1 commit into from
Aug 27, 2023

Conversation

csukuangfj
Copy link
Contributor

No description provided.

@@ -82,7 +82,7 @@ static void byteswap_tensor(ggml_tensor * tensor) {
} while (0)
#define BYTESWAP_TENSOR(t) \
do { \
byteswap_tensor(tensor); \
byteswap_tensor(t); \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you clarify what issues this is causing? And why do we need to switch from tensor to t?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The current implementation is misleading. The macro accepts an argument, but it is never used.

  2. It has not caused errors so far because the place where the macro is used exists a variable with name 'tensor'. Had you changed the variable name, would the code be broken.

@ggerganov ggerganov merged commit aad2dad into ggerganov:master Aug 27, 2023
@csukuangfj csukuangfj deleted the minor branch August 27, 2023 16:07
jacobwu-b pushed a commit to jacobwu-b/Transcriptify-by-whisper.cpp that referenced this pull request Oct 24, 2023
jacobwu-b pushed a commit to jacobwu-b/Transcriptify-by-whisper.cpp that referenced this pull request Oct 24, 2023
vonstring pushed a commit to vonstring/whisper.cpp that referenced this pull request Nov 7, 2023
landtanin pushed a commit to landtanin/whisper.cpp that referenced this pull request Dec 16, 2023
iThalay pushed a commit to iThalay/whisper.cpp that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants