Fix the Windows pthread_create shim (Assertion failed: rc == 0) #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation doesn't actually set the out parameter, and it returns 0 on failure instead of on success.
mattsta
pushed a commit
to mattsta/whisper.cpp
that referenced
this pull request
Apr 1, 2023
Co-authored-by: Jong Wook Kim <jongwook@nyu.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation doesn't actually set the out parameter, and it returns 0 on failure instead of on success.
This should fix people hitting the
Assertion failed: rc == 0failure.I also made a change to fix the compiler flags to enable AVX2 in the MSVC build.
Should address at least some of the problems mentioned in #5.