-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset ctx->t_start_us when calling whisper_reset_timings() #1434
Merged
ggerganov
merged 1 commit into
ggerganov:master
from
bjnortier:reset_print_timings_for_repeated_transcriptions
Nov 7, 2023
Merged
Reset ctx->t_start_us when calling whisper_reset_timings() #1434
ggerganov
merged 1 commit into
ggerganov:master
from
bjnortier:reset_print_timings_for_repeated_transcriptions
Nov 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before. "total time" is time from initial app startup to finish of first transcription. Subsequent transcriptions show total time from app startup.
|
After. "total time" shows transcription time
|
ggerganov
approved these changes
Nov 7, 2023
vonstring
pushed a commit
to vonstring/whisper.cpp
that referenced
this pull request
Nov 7, 2023
…gerganov#1434) Co-authored-by: Ben Nortier <ben@bjnortier.com>
felrock
pushed a commit
to felrock/whisper.cpp
that referenced
this pull request
Nov 18, 2023
…gerganov#1434) Co-authored-by: Ben Nortier <ben@bjnortier.com>
landtanin
pushed a commit
to landtanin/whisper.cpp
that referenced
this pull request
Dec 16, 2023
…gerganov#1434) Co-authored-by: Ben Nortier <ben@bjnortier.com>
iThalay
pushed a commit
to iThalay/whisper.cpp
that referenced
this pull request
Sep 23, 2024
…gerganov#1434) Co-authored-by: Ben Nortier <ben@bjnortier.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
ctx->t_start_us
is not reset when calling whisper_reset_timings(). This leads to an incorrect "total time" when doing consecutive transcription calls. In the SwiftUI example app it also outputs the total time from app startup (which loads the model) to when the transcription finishes.See below for example log outputs