CI : Rectify the Clang-Related workflow issues #1551
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that the CI related to
clang
is actually not working. Firstly, we did not installclang
, so it should have actually fallen back togcc/g++
. This means that we have not tested whether it compiles successfully onclang
. Secondly, since we are using Docker, we should useset -e
to tell the shell inside Docker to exit immediately when it encounters an error. This way, our GitHub action can catch the error, otherwise, it will be like the following situation.https://github.com/ggerganov/whisper.cpp/actions/runs/6980309523/job/18997081462?pr=1549#step:4:1836
Before:
After: