Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI : Add CUDA 11.8.0 support #1554

Merged
merged 4 commits into from
Nov 27, 2023
Merged

Conversation

bobqianic
Copy link
Collaborator

The reason for the inability to run is due to the incompatibility between the CUDA driver and CUDA toolkit. Previously, the CI for CUDA used version 12.1.0 of the CUDA toolkit, which requires a driver of at least version >=527.41 on Windows. The file whisper.cpp will dynamically link with the runtime in the CUDA toolkit, and the runtime will in turn dynamically link with the driver. The incompatibility causes it to fail to run. The solution is simple: adding a Windows binary compiled with version 11.X of the CUDA toolkit can solve the problem.

image

image

Reference: here

Closes #1552

@tamo
Copy link
Contributor

tamo commented Nov 26, 2023

Just out of curiosity...
Are there some users who cannot update their drivers?
In other words, can't we just say "please update your driver" and keep our CI simple?
IIRC, nvidia is slow to declare EOL.

@bobqianic
Copy link
Collaborator Author

Are there some users who cannot update their drivers?

Yes, there are certain users who might face issues updating their drivers. This includes individuals using Kepler GPUs, such as the K80 or K40 models, and those who do not have administrative privileges on their computers. Also, for instance, some users who have installed other software might need specific versions of CUDA drivers. It would be quite troublesome to reinstall drivers many times just to run whisper.cpp.

@bobqianic
Copy link
Collaborator Author

can't we just say "please update your driver" and keep our CI simple?

Yes. We can also mention that in README. Actually, adding a CI won’t waste much time, as they run in parallel. The total duration of the CI is determined by the longest running one. Currently, the longest ones are armv7 and ppc64le in ubuntu-latest-gcc. In theory, these could be merged with ubuntu-latest, which would speed up the CI process.

@tamo
Copy link
Contributor

tamo commented Nov 26, 2023

Wow, thanks for the excellent explanation, bobqianic! 💯

Copy link
Owner

@ggerganov ggerganov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for looking into this @bobqianic !

Speeding-up the CI would be useful in case you have ideas how to do it!

@ggerganov ggerganov merged commit bfacd9f into ggerganov:master Nov 27, 2023
37 checks passed
@bobqianic bobqianic deleted the cudaworkflow-fix branch November 27, 2023 17:55
landtanin pushed a commit to landtanin/whisper.cpp that referenced this pull request Dec 16, 2023
* try to fix cublas build in CI

* add multiple cuda-toolkit version

* Update build.yml

* Disable CUDA-toolkit 10.2.89
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why not runing whisper CUDA on GPU 1050TI on windows?
3 participants