Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

whisper.android: Return output from benchmarks #1785

Merged
merged 1 commit into from
Jan 19, 2024
Merged

whisper.android: Return output from benchmarks #1785

merged 1 commit into from
Jan 19, 2024

Commits on Jan 19, 2024

  1. whisper.android: Return output from benchmarks 

    Benchmarks are failing because JNI expects a jstring and the benchmarks
are missing a return statement (i.e., returning null). The functions
actually build a jstring but don't return it, so this seems to have been
an oversight.

This patch returns the jstring and now the benchmarks run successfully.

Fixes ggerganov#1783.
    @luciferous
    luciferous committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    02c4f15 View commit details
    Browse the repository at this point in the history