common: fix wav buffer detection #1819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggerganov
approved these changes
Jan 30, 2024
bygreencn
added a commit
to bygreencn/whisper.cpp
that referenced
this pull request
Feb 3, 2024
* ggerganov/master: (60 commits) sync : ggml (#0) ggml : fix IQ3_XXS on Metal (llama/5219) sync : ggml (llama/0) Faster AVX2 dot product for IQ2_XS (llama/5187) SOTA 3-bit quants (llama/5196) ggml alloc: Fix for null dereference on alloc failure (llama/5200) Nomic Vulkan backend (llama/4456) ggml : add max buffer sizes to opencl and metal backends (llama/5181) metal : free metal objects (llama/5161) gguf : fix comparison (ggml/715) `ggml_cuda_cpy` support for 4d tensors and float16->float32 upcasting (ggml/686) gguf : add input validation, prevent integer overflows (ggml/709) ci : fix yolo URLs + fix metal capture (ggml/712) metal : add debug capture backend function (ggml/694) common : fix wav buffer detection (ggerganov#1819) server : add fields to `verbose_json` response (ggerganov#1802) make : update MSYS_NT (ggerganov#1813) talk-llama : sync llama.cpp sync : ggml ggml : add Vulkan backend (llama/2059) ...
jiahansu
pushed a commit
to WiseSync/whisper.cpp
that referenced
this pull request
Apr 17, 2024
viktor-silakov
pushed a commit
to viktor-silakov/whisper_node_mic.cpp
that referenced
this pull request
May 11, 2024
iThalay
pushed a commit
to iThalay/whisper.cpp
that referenced
this pull request
Sep 23, 2024
iThalay
pushed a commit
to iThalay/whisper.cpp
that referenced
this pull request
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For edge cases, WAV files can be smaller than 256 bytes, although I doubt that Whisper can transcribe anything from them...
The specification states that both
RIFFandWAVEshould exist for WAV files.Then, I also check the file size based on the RIFF specification.