Embed Metal library source into compiled binary #1842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enable by setting WHISPER_EMBED_METAL_LIBRARY
ggerganov
reviewed
Feb 9, 2024
There was a problem hiding this comment.
Huh, that's a neat trick!
Is there a way to avoid the extra file ggml-metal-embed.s?
For example, could it be part of ggml-metal.m just surrounded by a specific define like GGML_METAL_BUILD_ASM
#ifndef GGML_METAL_BUILD_ASM
... ggml-metal.m source ...
#else
... ggml-metal-embed.s ...
#endifOr something similar - just looking for ways to avoid the extra file
CMakeLists.txt
Outdated
| @@ -68,6 +68,7 @@ if (APPLE) | |||
| option(WHISPER_METAL_NDEBUG "whisper: disable Metal debugging" OFF) | |||
| option(WHISPER_COREML "whisper: enable Core ML framework" OFF) | |||
| option(WHISPER_COREML_ALLOW_FALLBACK "whisper: allow non-CoreML fallback" OFF) | |||
| option(WHISPER_EMBED_METAL_LIBRARY "whisper: embed Metal library" OFF) | |||
There was a problem hiding this comment.
Rename to WHISPER_METAL_EMBED_LIBRARY
There was a problem hiding this comment.
Updated also the preprocessor directive name
|
It looks like it is not possible to embed this approach into Objective-C source, however if the aim is to avoid having another file in the source tree, I updated the build process so that the assembly is autogenerated during the build phase. |
ggerganov
approved these changes
Feb 11, 2024
jiahansu
pushed a commit
to WiseSync/whisper.cpp
that referenced
this pull request
Apr 17, 2024
* ggml : embed Metal library source (ggml-metal.metal) into binary enable by setting WHISPER_EMBED_METAL_LIBRARY * rename the build option * rename the preprocessor directive * generate Metal library embedding assembly on-fly during build process
viktor-silakov
pushed a commit
to viktor-silakov/whisper_node_mic.cpp
that referenced
this pull request
May 11, 2024
* ggml : embed Metal library source (ggml-metal.metal) into binary enable by setting WHISPER_EMBED_METAL_LIBRARY * rename the build option * rename the preprocessor directive * generate Metal library embedding assembly on-fly during build process
jiahansu
pushed a commit
to WiseSync/whisper.cpp
that referenced
this pull request
May 15, 2024
* ggml : embed Metal library source (ggml-metal.metal) into binary enable by setting WHISPER_EMBED_METAL_LIBRARY * rename the build option * rename the preprocessor directive * generate Metal library embedding assembly on-fly during build process
iThalay
pushed a commit
to iThalay/whisper.cpp
that referenced
this pull request
Sep 23, 2024
* ggml : embed Metal library source (ggml-metal.metal) into binary enable by setting WHISPER_EMBED_METAL_LIBRARY * rename the build option * rename the preprocessor directive * generate Metal library embedding assembly on-fly during build process
iThalay
pushed a commit
to iThalay/whisper.cpp
that referenced
this pull request
Sep 23, 2024
* ggml : embed Metal library source (ggml-metal.metal) into binary enable by setting WHISPER_EMBED_METAL_LIBRARY * rename the build option * rename the preprocessor directive * generate Metal library embedding assembly on-fly during build process
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds option to embed ggml-metal.metal file directly into exectuable.