-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow a regular expression to describe tokens to suppress #1997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example: --suppress-tokens-re "[,\.]|[ ]?[0-9]+" will suppress commas, periods, and numeric tokens. Technique inspired by openai/whisper#1041 Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
ggerganov
approved these changes
Mar 28, 2024
It should go without saying that I'm fine with your changes. |
ulatekh
commented
Apr 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accepted changes
ulatekh
force-pushed
the
suppress_tokens_re
branch
4 times, most recently
from
April 1, 2024 17:03
51dad18
to
4853a90
Compare
ulatekh
force-pushed
the
suppress_tokens_re
branch
from
April 3, 2024 21:15
3c7b4f8
to
ee751d7
Compare
ggerganov
approved these changes
Apr 9, 2024
jiahansu
pushed a commit
to WiseSync/whisper.cpp
that referenced
this pull request
Apr 17, 2024
* Allow a regular expression to describe tokens to suppress. Example: --suppress-tokens-re "[,\.]|[ ]?[0-9]+" will suppress commas, periods, and numeric tokens. Technique inspired by openai/whisper#1041 Co-authored-by: Georgi Gerganov <ggerganov@gmail.com> * Blind change to fix Java test. --------- Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
viktor-silakov
pushed a commit
to viktor-silakov/whisper_node_mic.cpp
that referenced
this pull request
May 11, 2024
* Allow a regular expression to describe tokens to suppress. Example: --suppress-tokens-re "[,\.]|[ ]?[0-9]+" will suppress commas, periods, and numeric tokens. Technique inspired by openai/whisper#1041 Co-authored-by: Georgi Gerganov <ggerganov@gmail.com> * Blind change to fix Java test. --------- Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
iThalay
pushed a commit
to iThalay/whisper.cpp
that referenced
this pull request
Sep 23, 2024
* Allow a regular expression to describe tokens to suppress. Example: --suppress-tokens-re "[,\.]|[ ]?[0-9]+" will suppress commas, periods, and numeric tokens. Technique inspired by openai/whisper#1041 Co-authored-by: Georgi Gerganov <ggerganov@gmail.com> * Blind change to fix Java test. --------- Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
iThalay
pushed a commit
to iThalay/whisper.cpp
that referenced
this pull request
Sep 23, 2024
* Allow a regular expression to describe tokens to suppress. Example: --suppress-tokens-re "[,\.]|[ ]?[0-9]+" will suppress commas, periods, and numeric tokens. Technique inspired by openai/whisper#1041 Co-authored-by: Georgi Gerganov <ggerganov@gmail.com> * Blind change to fix Java test. --------- Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example: --suppress-tokens-re "[,.]|[ ]?[0-9]+" will suppress commas, periods, and numeric tokens.
Technique inspired by openai/whisper#1041 .
I used something like this while working with OpenAI's whisper & wanted to use it in this project.