Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

whisper : fixes #2217

Merged
merged 2 commits into from
Jun 6, 2024
Merged

whisper : fixes #2217

merged 2 commits into from
Jun 6, 2024

Conversation

ggerganov
Copy link
Owner

@ggerganov ggerganov commented Jun 6, 2024 •
edited
Loading

  • move mel_calc to whisper_state
  • mel_calc uses backend of whisper_state instead of whisper_context
  • alloc kv caches using backend of whisper_state instead of whisper_context
  • less C++ in struct whisper_mel

@ggerganov
Copy link
Owner Author

@iboB Could you give this PR a few tests to make sure I don't break something

iboB
iboB approved these changes Jun 6, 2024
View reviewed changes
Copy link
Collaborator

@iboB iboB left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Tested with several inputs. Everything seems to be in order

@ggerganov ggerganov merged commit 87acd6d into master Jun 6, 2024
87 of 92 checks passed
@ggerganov ggerganov deleted the gg/some-fixes branch June 6, 2024 15:51
iThalay pushed a commit to iThalay/whisper.cpp that referenced this pull request Sep 23, 2024
@ggerganov @iThalay
whisper : whisper_state/backend fixes (ggerganov#2217)
ecd5522 
* whisper : fixes

* ci : WHISPER_CUBLAS -> WHISPER_CUDA
iThalay pushed a commit to iThalay/whisper.cpp that referenced this pull request Sep 23, 2024
@ggerganov @iThalay
whisper : whisper_state/backend fixes (ggerganov#2217)
bbe5d72 
* whisper : fixes

* ci : WHISPER_CUBLAS -> WHISPER_CUDA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iboB iboB iboB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ggerganov @iboB